ci: fix dapp-release workflow tag extraction #59
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore(main): release dapp 0.1.0-alpha.1 * chore: clean up dapp changelog entries --------- Co-authored-by: iexec-release-please-app[bot] <202620906+iexec-release-please-app[bot]@users.noreply.github.com> Co-authored-by: SeddikBellamine <[email protected]>
Comment on lines
+10
to
+11
| - rollback debug logging changes from develop branch ([404ce33](https://github.com/iExecBlockchainComputing/web3telegram-sdk/commit/404ce33e7d0705c274155813951284cd1830a3d2)) | ||
|
|
Contributor
There was a problem hiding this comment.
Suggested change
| - rollback debug logging changes from develop branch ([404ce33](https://github.com/iExecBlockchainComputing/web3telegram-sdk/commit/404ce33e7d0705c274155813951284cd1830a3d2)) |
this change doesn't seem particularly valuable to include
Member
|
Changes made obsolete by #60 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the tag extraction issue in the dapp-release workflow that was causing Docker build failures.
Problem
The workflow was failing with invalid Docker tag errors because the image-tag variable was empty due to failed tag extraction from git tags.
Solution
Changed the tag extraction method from parsing git tags to reading the version directly from dapp/package.json using grep and sed commands.
Benefits
Files Changed